fix: rename add-project to add_project in mux module#765
Merged
Conversation
ibetitsmike
force-pushed
the
mike/fix-mux-add-project-param
branch
from
5278e62 to
39e6d32
Compare
DevelopmentCats
approved these changes
Feb 27, 2026
Collaborator
DevelopmentCats
left a comment
DevelopmentCats
left a comment
There was a problem hiding this comment.
@ibetitsmike LGTM.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a Terraform naming convention violation by renaming the add-project variable to add_project in the mux module. Terraform variable names should use underscores instead of hyphens, and this change brings the module in line with standard Terraform conventions and the rest of the codebase. The version is bumped from 1.3.0 to 1.3.1 to reflect this breaking change.
Changes:
- Renamed
add-projectvariable toadd_projectin main.tf (variable declaration and all references) - Updated all README.md examples to use the new variable name and bumped version to 1.3.1
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| registry/coder/modules/mux/main.tf | Renamed variable declaration from add-project to add_project and updated references in templatefile |
| registry/coder/modules/mux/README.md | Updated version from 1.3.0 to 1.3.1 across all examples and corrected variable name usage to add_project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terraform variable names should use underscores, not hyphens. Renames the
add-projectvariable toadd_projectin the mux module.Changes:
main.tf: Renamed variable declaration and referencesREADME.md: Updated example usageBumped version: 1.3.0 → 1.3.1
Generated with Mux using Claude