fix(claude-code): don't pass --dangerously-skip-permissions in auto mode#846
fix(claude-code): don't pass --dangerously-skip-permissions in auto mode#846bdevore17 wants to merge 1 commit intocoder:mainfrom
Conversation
The task reporting code path unconditionally added --dangerously-skip-permissions regardless of the configured permission_mode. This meant workspaces using permission_mode="auto" got both --permission-mode auto AND --dangerously-skip-permissions, defeating the purpose of auto mode. Now only adds --dangerously-skip-permissions when no explicit permission mode is set (backward compat) or when bypassPermissions is the chosen mode. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@35C4n0r please review |
|
Have you tested this with tasks yet? I only ask because the reason we unconditionally added |
|
@DevelopmentCats yes i have. This still works as intended. The only difference is it first respects the permission_mode in the template. Right now, if you set permission_mode to |
Perfect! Thank you so much for the testing and the contribution. I will go ahead and put this through some rounds of testing just to confirm since this module is active, and then we can get this merged! 😸 |
Summary
start.shunconditionally adds--dangerously-skip-permissionsregardless of the configuredpermission_modepermission_mode = "auto"get both--permission-mode autoand--dangerously-skip-permissions, which defeats the purpose of auto mode--dangerously-skip-permissionswhen no explicit permission mode is set (backward compat) or whenbypassPermissionsis chosenTest plan
claude-continue-resume-task-session-auto-modetest verifying--dangerously-skip-permissionsis NOT passed whenpermission_mode=autoclaude-auto-permission-modetest to assert--dangerously-skip-permissionsis absentclaude-continue-resume-task-sessiontest still verifies default (no permission_mode) includes--dangerously-skip-permissions