Preverse error when return from failed precheck#24
Merged
Conversation
scsmithr
approved these changes
Aug 13, 2018
scsmithr
left a comment
scsmithr
left a comment
There was a problem hiding this comment.
I assume the commit msg should be "preserve"?
ammario
force-pushed
the
feature/preserve-error
branch
from
89e590d to
cb44b8a
Compare
Member
Author
|
Waiting on @nhooyr to agree with these changes before merging. |
Contributor
|
Commented in #23 |
ammario
force-pushed
the
feature/preserve-error
branch
from
cb44b8a to
6262031
Compare
ammario
force-pushed
the
feature/preserve-error
branch
from
6262031 to
d12fd6b
Compare
Member
Author
|
@nhooyr this is ready |
nhooyr
suggested changes
Aug 14, 2018
| return err | ||
| e.Reason = r.preCheck() | ||
| if e.Reason != nil { | ||
| return e.nilIfEmpty() |
Member
Author
There was a problem hiding this comment.
I think it can... At least it was causing a test error because it was.
Member
Author
There was a problem hiding this comment.
Even if we can prove that is never empty, that function will catch mistakes in-case the behavior changes in the future.
nhooyr
approved these changes
Aug 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #23