Skip to content

fix: prevent binary download failures with compressed server responses#812

Merged
EhabY merged 4 commits intomainfrom
fix/binary-download-compression
Mar 4, 2026
Merged

fix: prevent binary download failures with compressed server responses#812
EhabY merged 4 commits intomainfrom
fix/binary-download-compression

Conversation

@EhabY
Copy link
Collaborator

@EhabY EhabY commented Mar 2, 2026

Request identity encoding and disable axios decompression for all downloads to avoid failures when servers or proxies apply unexpected content encoding. Fall back to x-original-content-length header for progress tracking when content-length is absent.

Closes #810, #786

@EhabY EhabY self-assigned this Mar 2, 2026
@EhabY EhabY force-pushed the fix/binary-download-compression branch 4 times, most recently from f636d46 to 555a7e0 Compare March 4, 2026 13:35
@EhabY EhabY requested a review from jeremyruppel March 4, 2026 14:04
EhabY added 3 commits March 4, 2026 17:09
Request identity encoding and disable axios decompression for all
downloads to avoid failures when servers or proxies apply unexpected
content encoding. Fall back to x-original-content-length header for
progress tracking when content-length is absent.
@EhabY EhabY force-pushed the fix/binary-download-compression branch from 555a7e0 to 7aa9ea9 Compare March 4, 2026 14:12
@EhabY EhabY force-pushed the fix/binary-download-compression branch from 7aa9ea9 to e31b137 Compare March 4, 2026 14:13
Copy link

@jeremyruppel jeremyruppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EhabY EhabY merged commit 6e8e919 into main Mar 4, 2026
6 checks passed
@EhabY EhabY deleted the fix/binary-download-compression branch March 4, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to download binary: aborted. Binary download fails when server responds with content-encoding

2 participants