fix: defer Workspace Build output channel creation until first write#920
Merged
fix: defer Workspace Build output channel creation until first write#920
Conversation
EhabY
force-pushed
the
fix/lazy-build-output-channel
branch
from
4ae37be to
2b872b7
Compare
mtojek
approved these changes
Apr 28, 2026
Constructing TerminalOutputChannel previously called createOutputChannel and show(true) immediately, which forced the Output panel open even on reconnects to an already-running workspace where no build logs would ever be written. The empty channel was disposed shortly after, but the Output panel itself stayed visible. Defer both calls to the first write, so reconnects to a running workspace never create the channel and never pop the panel.
EhabY
force-pushed
the
fix/lazy-build-output-channel
branch
from
2b872b7 to
e4c4906
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TerminalOutputChannel's constructor previously calledcreateOutputChannelandshow(true)immediately, so the Output panel popped open every time we built aWorkspaceStateMachine— even on reconnects to an already-running workspace where no build logs would ever be written.createOutputChannelandshow(true)to the firstwrite(). Reconnects to a running workspace never create the channel and never pop the panel; real builds behave exactly as before.