Skip to content

ci: run tests on Windows and macOS#923

Merged
EhabY merged 2 commits intomainfrom
ci/cross-platform-tests
Apr 29, 2026
Merged

ci: run tests on Windows and macOS#923
EhabY merged 2 commits intomainfrom
ci/cross-platform-tests

Conversation

@EhabY
Copy link
Copy Markdown
Collaborator

@EhabY EhabY commented Apr 29, 2026

  • Add Windows and macOS to the unit and integration test matrices to catch cross-platform regressions automatically (path separators, shell quoting, .cmd shim resolution, etc. — see fix: Windows compatibility for tests, scripts, and Vitest Explorer #876 for prior offenders).
  • Linux keeps the full matrix (Electron 37 + latest, VS Code 1.106.0 + stable); Windows and macOS each run a single latest/stable smoke job to keep the matrix tight (+4 jobs total, all parallel).
  • xvfb-run is gated to Linux; Windows/macOS run pnpm test:integration directly since @vscode/test-electron handles platform-specific VS Code downloads.

Closes #882

Linux keeps the full matrix (Electron 37+latest, VS Code 1.106+stable);
Windows and macOS each run a single latest/stable smoke job to catch
cross-platform regressions like path-separator and shell-quoting bugs
(see #876). xvfb is gated to Linux; Win/Mac use vscode-test directly.

Closes #882
Copy link
Copy Markdown
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

- Display friendlier names (Linux/Windows/macOS) instead of raw runner labels.
- Collapse the two conditional integration steps into one with an inline
  `xvfb-run -a` prefix gated on Linux.
- Pin windows-2025 and macos-15 to match how Linux is already pinned, so
  GitHub-hosted image transitions don't surprise CI.
@EhabY EhabY merged commit 78fd756 into main Apr 29, 2026
10 checks passed
@EhabY EhabY deleted the ci/cross-platform-tests branch April 29, 2026 12:20
@EhabY EhabY self-assigned this Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: run tests on Windows and macOS in addition to Linux

2 participants