New incompatibility with Gin 1.11.0

[camille-sound4]

When updating Gin to 1.11.0, the Accept is not working anymore, due to an extra verification done in Gin.

This is due to the Gin commit prevention of Hijack() runtime panics, which now checks in responseWriter.Hijack that the writer has not yet been written, and returns an error otherwise ("gin: response already written").

The worst is that all this is due to a Gin specific patch made here a long time ago Gin compatabilty.
This calls ginWriter.WriteHeaderNow(), which turns to set the w.size to 0 before calling Hijack().

I am not sure how this should be corrected, as it seems it depends on Gin version...

[mafredri]

It seems the Gin change breaks the ability to write headers before hijacking, I suggest raising an issue on the Gin issue tracker.

I'd like to a void resorting to writing headers manually in this project.

[camille-sound4]

Thanks Matthias.
I added an issue on gin 4372

[appleboy]

See the new patch: gin-gonic/gin#4373

[mafredri]

Awesome, thanks for sharing the update @appleboy and for the fast turn-around!