feat: add reloadable LSP logging and setTrace support#111
Merged
coder3101 merged 5 commits intoMay 5, 2026
Conversation
coder3101
reviewed
May 5, 2026
coder3101
reviewed
May 5, 2026
coder3101
reviewed
May 5, 2026
coder3101
reviewed
May 5, 2026
Owner
coder3101
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
Some feedback and rest LGTM
Contributor
Author
Thank you for your review, I've addressed the comments. Would you like me to squash the commits into one |
coder3101
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements a more idiomatic LSP logging system. It shifts from static file-based logging to a dynamic, reloadable system that communicates directly with the LSP client.
neovim user experience (e.g. via
:messages):VS Code user experience (old output channel):
This will be even better when an Extension uses the modern LogOutputChannel (with
options: {log: true}).Changes
logmodule: Added a custom tracing layer (ClientLogger) that forwards logs to the LSP client via an asynchronous channel.tracing_subscriber::reloadto allow real-time log level updates.$/setTracenotification handler inProtoLanguageServer.How to test
$/setTracenotification with valueverbose.TRACEandDEBUGlogs appearing in the editor's output channel.Compatibility
I've replaced the previous file-logging implementation to avoid cluttering. Please let me know if you would prefer to keep the file appender as a concurrent logging layer; I can easily add it back as an additional tracing layer.
Fixes #110