Skip to content

fix(copy): support paths with slashes in includeDirs#103

Merged
helizaga merged 1 commit intomainfrom
fix-includedirs-slash-paths
Feb 9, 2026
Merged

fix(copy): support paths with slashes in includeDirs#103
helizaga merged 1 commit intomainfrom
fix-includedirs-slash-paths

Conversation

@helizaga
Copy link
Collaborator

@helizaga helizaga commented Feb 9, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Improved pattern matching precision for directory paths with nested components, enhancing the accuracy of directory filtering operations.

@helizaga helizaga requested a review from NatoBoram as a code owner February 9, 2026 19:31
@helizaga helizaga merged commit 386b9b2 into main Feb 9, 2026
1 check was pending
@helizaga helizaga deleted the fix-includedirs-slash-paths branch February 9, 2026 19:31
@coderabbitai
Copy link

coderabbitai bot commented Feb 9, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

The copy_directories function in lib/copy.sh has been enhanced to differentiate between slash-containing patterns and simple name patterns. When patterns include directory components (slash), the function now uses path-based matching; otherwise, it uses name-based matching for improved precision.

Changes

Cohort / File(s) Summary
Directory Lookup Pattern Matching
lib/copy.sh
Updated copy_directories function to use -path matching for patterns containing slashes and -name matching for simple patterns, improving precision of directory lookups.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A hop and a skip through paths so true,
Where slashes now guide what we find for you,
Precision improved with each clever command,
The copy script dances across the land! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-includedirs-slash-paths

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments