-
Notifications
You must be signed in to change notification settings - Fork 41
feat: add gemini adapter #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
helizaga
merged 2 commits into
coderabbitai:main
from
tsuno08:feature/add-gemini-adapter
Nov 29, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| #!/usr/bin/env bash | ||
| # Gemini CLI adapter | ||
|
|
||
| # Check if Gemini is available | ||
| ai_can_start() { | ||
| command -v gemini >/dev/null 2>&1 | ||
| } | ||
|
|
||
| # Start Gemini in a directory | ||
| # Usage: ai_start path [args...] | ||
| ai_start() { | ||
| local path="$1" | ||
| shift | ||
|
|
||
| if ! ai_can_start; then | ||
| log_error "Gemini CLI not found. Install with: npm install -g @google/gemini-cli" | ||
| log_info "Or: brew install gemini-cli" | ||
| log_info "See https://github.com/google-gemini/gemini-cli for more info" | ||
| return 1 | ||
| fi | ||
|
|
||
| if [ ! -d "$path" ]; then | ||
| log_error "Directory not found: $path" | ||
| return 1 | ||
| fi | ||
|
|
||
| # Change to the directory and run gemini with any additional arguments | ||
| (cd "$path" && gemini "$@") | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
LGTM! Verify all three completion files were updated.
The addition of
geminito the AI tool list is correct and maintains alphabetical ordering. However, per coding guidelines, all three completion files (gtr.bash, _git-gtr, gtr.fish) must be updated when adding new AI adapters.As per coding guidelines, verify that gtr.bash and gtr.fish were also updated with the
geminiadapter:🏁 Script executed:
Length of output: 187
Update gtr.bash and gtr.fish to include the
geminiAI adapter.Verification confirms that
geminiwas added to_git-gtr(line 88) but is missing fromgtr.bashandgtr.fish. Per coding guidelines, all three completion files must be updated when adding new AI adapters. Both files require thegeminientry in their AI tool lists.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderabbitai
Currently, AI tool list completion (for the --ai flag) is only implemented in _git-gtr
(Zsh). gtr.bash and gtr.fish do not yet have the logic to complete AI tool names.
If we want to support this in gtr.bash and gtr.fish, I would need to implement the
completion logic itself first. Should I include that implementation in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 2129
🏁 Script executed:
Length of output: 562
@tsuno08, thank you for the clarification! You're absolutely right—I've confirmed that gtr.bash and gtr.fish do not currently have any flag completion logic for
--ai(or even--editor). Only_git-gtr(Zsh) has this functionality.Recommendation: Keep this PR focused on adding the
geminiadapter. Implementing completion logic for--aiand--editorflags in gtr.bash and gtr.fish would be a separate feature enhancement and would expand the scope significantly.Your current changes are correct—you've properly updated
_git-gtr, which is the only completion file that currently supports AI tool name completion.Suggested follow-up: If you'd like to add this completion support to bash and fish shells, that would make a great follow-up PR or issue. Would you like me to create an issue to track this enhancement?
🐰💭
⛔ Learnings removed
🧠 Learnings used