refactor: code cleanup, utils extraction, and test improvements #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move background tasks and rate-limit handler into utils.py - Reference TEMPLATES from config instead of inline Jinja2Templates - Adopt Given/When/Then docstrings for test clarity - Parametrize some tests and consolidate code across query_parser tests - Add pytest.warns context handler to test_parse_repo_source_with_failed_git_command
filipchristiansen
force-pushed
the
refactor/code_cleanup_utils_and_tests
branch
from
a2ae334 to
63b5f23
Compare
cyclotruc
reviewed
Jan 19, 2025
cyclotruc
approved these changes
Jan 23, 2025
FOLKS-Tech
pushed a commit
to FOLKS-Tech/gitingest
that referenced
this pull request
Sep 5, 2025
…ramp-labs#141) * Refactor code for lifespan, template usage, and improved tests - Move background tasks and rate-limit handler into utils.py - Reference TEMPLATES from config instead of inline Jinja2Templates - Adopt Given/When/Then docstrings for test clarity - Parametrize some tests and consolidate code across query_parser tests - Add pytest.warns context handler to test_parse_repo_source_with_failed_git_command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR centralizes key improvements in the application’s structure and testing approach:
Lifespan & Cleanup in
utils.pyrate_limit_exception_handler, andlifespanfrommain.pyinto a newutils.pymodule.Unified Template Usage
Jinja2Templatesinstantiations, replacing them with the sharedTEMPLATESfromconfig.py.TEMPLATESdirectly for more consistent template loading.Test Enhancements
query_parser.pytest.warnsto capture warnings explicitly intest_parse_repo_source_with_failed_git_command.