refactor: refactor codebase to unify server module and update file paths #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rences accordingly
cyclotruc
requested changes
Jan 21, 2025
Member
cyclotruc
left a comment
cyclotruc
left a comment
There was a problem hiding this comment.
Two things:
1 - We should make it so the static ressources are not served under /server/ subpath
1 - We should split the config in 2 files, maybe rename them server_config and config to fix the CLI bug
filipchristiansen
force-pushed
the
refactor/server-structure
branch
from
af29daa to
1a1d587
Compare
cyclotruc
approved these changes
Jan 24, 2025
Member
|
@filipchristiansen Finally merged, decided to move utils into server and adjusted readme, now we have a strong structure to improve upon! |
FOLKS-Tech
pushed a commit
to FOLKS-Tech/gitingest
that referenced
this pull request
Sep 5, 2025
…ths (coderamp-labs#142) * Refactor project into a dedicated 'server' module and update all references accordingly --------- Co-authored-by: Romain Courtois <romain@coderamp.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorganizes the codebase to place all application logic, routers, static files, and templates within a new
servermodule. Key changes include:main.py,routers,query_processor.py, andserver_utils.pyinto theserverdirectoryserver.routers,server.server_utils)src/statictosrc/server/staticand templates fromsrc/templatestosrc/server/templatesCMDto point toserver.main:appThis refactor provides a cleaner, more consistent structure for the FastAPI application and its related components.