Skip to content

Conversation

@filipchristiansen
Copy link
Contributor

@filipchristiansen filipchristiansen commented Jun 26, 2025

Consolidates our lint/format tooling around Ruff, deprecates the old .gitingest spec, and sweeps the codebase for consistency & hidden bugs (no functional API changes).

Area Key changes
Pre-commit black / darglint hooks → ruff-check & ruff-format
New docstring linter: pydoclint
Dependencies Drop tomli; tighten typing_extensions; add eval-type-backport
Remove black, djlint, pylint from requirements-dev
Ignore handling Deprecate .gitingest (TOML)
New .gitingestignore using git-wildmatch (parses via existing _parse_ignore_file)
Tooling / config New [tool.ruff] section (lint + format + isort rules)
Remove [tool.black]; keep minimal [tool.isort] for now
Refactor / style from __future__ import annotations, kw-only args, richer types
Re-order params & __all__, move type-only imports under if TYPE_CHECKING
Extract CLI args to TypedDict[_CLIArgs]; form data to pydantic.QueryForm
Deduplicate cli.main / _async_main & split large functions
pathlib everywhere, no file-IO in async, constants > magic numbers
Delete is_text_file – logic now lives in FileSystemNode.content
Bug fix Eliminated silent bug in notebook_utils._process_cell
Docs / badges README badge refresh
Tests Updated fixtures & assertions

⚠️ Breaking changes

  • New file: .gitingestignore (drop-in git-wildmatch).
    Existing .gitingest is now deprecated.

No other functional API or CLI changes.

@filipchristiansen filipchristiansen force-pushed the chore/ruff-migration-code-cleanup branch 2 times, most recently from 68ac33b to 07c0520 Compare June 26, 2025 15:04

This comment was marked as outdated.

@filipchristiansen filipchristiansen force-pushed the chore/ruff-migration-code-cleanup branch from 07c0520 to b48ddcc Compare June 26, 2025 15:19
@filipchristiansen filipchristiansen marked this pull request as draft June 26, 2025 15:22
@filipchristiansen filipchristiansen marked this pull request as draft June 26, 2025 15:22
@filipchristiansen filipchristiansen force-pushed the chore/ruff-migration-code-cleanup branch 3 times, most recently from b2e0825 to 6d919aa Compare June 28, 2025 10:22
@filipchristiansen filipchristiansen force-pushed the chore/ruff-migration-code-cleanup branch from 8cde625 to d36a975 Compare June 28, 2025 12:15
@filipchristiansen filipchristiansen marked this pull request as ready for review June 28, 2025 12:30

This comment was marked as outdated.

Copy link
Member

@cyclotruc cyclotruc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much needed cleanup after dropping Python 3.7 support, thanks @filipchristiansen

@filipchristiansen filipchristiansen merged commit 2f447ae into main Jun 28, 2025
18 checks passed
@filipchristiansen filipchristiansen deleted the chore/ruff-migration-code-cleanup branch June 28, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants