fix: update CI workflow for consistency, change manifest/digest logic #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the Dockerfile stage name from 'as' to 'AS' for consistency. - Removed conditional checks for pull requests in the GitHub Actions workflow to ensure builds run on all events. - Simplified the Docker build process by setting the push option to true and ensuring both AMD64 and ARM64 digests are used in the manifest creation step.
… using matrix - Consolidated AMD64 and ARM64 build jobs into a single job with a matrix strategy. - Added QEMU setup for cross-platform builds. - Simplified image tagging and digest handling for both architectures. - Enhanced manifest creation to include both architecture images.
…ests - Added conditions to skip login, push, and manifest creation steps when the event is a pull request. - Enhanced manifest creation to process each tag individually for better clarity and management. - Updated image inspection to handle multiple tags, improving the workflow's robustness.
atyrode
changed the title
|
At last. I hope! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #23 complicated the CI/CD workflow too much and this reverts part of its logic to simplify the building flow.