feat: create Modal component #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored AuthModal to utilize a new Modal component for improved code organization and reusability. - Consolidated styles by importing Modal.scss into AuthModal.scss, reducing redundancy. - Updated class names in AuthModal to follow BEM methodology for better clarity and maintainability.
…d timeout - Removed inline styles and the message div for a cleaner HTML structure. - Streamlined the window closing logic by directly calling window.close() without a delay.
- Introduced state management for modal visibility and exit animations in AuthGate. - Updated AuthModal to accept new props for exit animation handling. - Refactored Modal component to apply animations via inline styles, improving flexibility. - Added new keyframes for fade-out and zoom-out animations to enhance user experience.
…d on branch - Modified the platforms setting in the Docker build workflow to conditionally include ARM64 support only when on the main branch, enhancing build efficiency and flexibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the modal logic out of
AuthModalinto a genericModalcomponent that can be re-used by other part of the app.