fix: allow scrolling over embeddables #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added CSS variable for pointer-events to manage interaction during scrolling. - Introduced lockEmbeddables function to disable pointer-events while scrolling and reset after scrolling ends using a debounced function. - Updated ExcalidrawWrapper to integrate scrolling behavior with embeddables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the click-through property of embeddable now conditional to the user not scrolling.
This greatly enhance the usability on MacOS and trackpads that allow scrolling with fingers, as the scrolling would be abruptly interrupted as soon as the mouse hovered any embeddable, making the navigation experience quite frustrating.