Add images to work experience #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for displaying featured images in work experience entries with lightbox gallery view. Closes coderdiaz#8
Contributor
Author
|
@coderdiaz, Pls review the PR. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds image gallery functionality to work experience entries, allowing job entries to display thumbnail images that open in a lightbox viewer when clicked.
- Adds optional
imagesfield to job collection schema - Creates a new React-based
ImageLightboxcomponent with navigation controls - Integrates image thumbnails and lightbox functionality into the
WorkExperiencecomponent
Reviewed Changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/content.config.ts | Updates job collection schema to support optional image arrays |
| src/content/jobs/reboot-studio/index.mdx | Adds sample image paths to demonstrate new image gallery feature |
| src/content/jobs/sofia/index.mdx | Minor formatting fix (adds line number to trailing content) |
| src/components/ui/WorkExperience.astro | Adds image thumbnail rendering and lightbox initialization script |
| src/components/ui/ImageLightbox.tsx | New React component implementing image lightbox with navigation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
@shrvansudhakara Could you check the Copilot review? Thanks 🙏 |
coderdiaz
requested changes
Oct 30, 2025
- Removed `document.addEventListener('DOMContentLoaded', ...)` wrapper
- Script now executes immediately when the component renders
- Compatible with Astro's client-side navigation and view transitions
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Remove unnecessary Promise.all from image mapping - Use stable keys for React list items - Implement event delegation to prevent memory leaks - Add accessibility attributes (role, aria-modal, aria-label) - Add keyboard navigation support (Escape, Arrow keys)
- Fix top-level return error in Astro script by wrapping logic in if block - Implement Framer Motion for smooth lightbox animations - Preserve aspect ratio for vertical and horizontal images - Add fade and scale transitions matching reference design - Add body scroll lock when lightbox is open
Contributor
Author
|
@coderdiaz, Pls review the revisions |
Owner
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR adds support for displaying featured images in work experience entries with an interactive lightbox gallery. Users can now showcase visual highlights from their roles (project screenshots, team photos, etc.).
Fixes #8
📝 Changes
Modified Files
src/content.config.ts- Addedimagesfield to job collection schemasrc/components/ui/WorkExperience.astro- Added image thumbnail display and lightbox integrationsrc/content/jobs/- Reorganized into subdirectories (each job in its own folder)New Files
src/components/ui/ImageLightbox.tsx- React component for full-screen image gallery with navigationsrc/content/jobs/reboot-studio/index.mdx- Restructured with example imagessrc/content/jobs/reboot-studio/image-*.jpg- Example featured images🚀 Features
🔧 Implementation Details
Schema update:
Directory structure:
Lightbox features:
✅ Testing
📸 Screenshots
Thumbnail Gallery:
Lightbox View:
🎥 Demo
demo.mp4
🔗 Related
Note: Feature is optional and won't affect experiences without image(s).