Important improvements #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the job data model to use optional end dates instead of the string literal "Now" for ongoing positions, and generalizes utility functions to be more reusable across different content types.
- Replaced string literal "Now" with optional
tofield for representing ongoing jobs - Refactored sorting functions to be generic and applicable to multiple content types
- Updated job content files and UI components to handle the new optional field pattern
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/utils.ts | Replaced domain-specific sorting functions with generic type-safe alternatives that handle date ranges and year sorting |
| src/pages/index.astro | Updated imports to use renamed generic sorting functions |
| src/content.config.ts | Changed job schema to use optional to field instead of union type with "Now" |
| src/content/jobs/*.mdx | Updated job entries to use optional to field or numeric year instead of "Now" string |
| src/components/ui/WorkExperience.astro | Added fallback to display "Present" when to field is undefined |
| src/lib/constants.ts | Fixed formatting issues (trailing commas, semicolons) and changed avatar image format |
| src/components/partials/Header.astro | Reformatted component for better code style consistency |
| src/assets/images/avatar.png | Added new PNG avatar image to replace JPEG |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.