Skip to content

feat: add account verifier url config#504

Merged
mfrancisc merged 1 commit intocodeready-toolchain:masterfrom
mfrancisc:accountverifierconfig
May 4, 2026
Merged

feat: add account verifier url config#504
mfrancisc merged 1 commit intocodeready-toolchain:masterfrom
mfrancisc:accountverifierconfig

Conversation

@mfrancisc
Copy link
Copy Markdown
Contributor

@mfrancisc mfrancisc commented Apr 30, 2026

Description

Add account verifier URL configuration so we can configure provide the URL to the registration service.

Checks

  1. Did you run make generate target? yes

  2. Did make generate change anything in other projects (host-operator)? yes

  3. In case of new CRD, did you the following? yes

  4. In case other projects are changed, please provides PR links.

Summary by CodeRabbit

  • New Features
    • Added accountVerifierURL optional configuration parameter to enable specification of the account verifier service endpoint.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

Walkthrough

Adds a new optional accountVerifierURL configuration field to RegistrationServiceConfig. The change includes the Go type definition, corresponding deepcopy and OpenAPI schema generation, and API documentation. No functional logic is modified.

Changes

Cohort / File(s) Summary
Configuration Type Definition
api/v1alpha1/toolchainconfig_types.go, api/v1alpha1/zz_generated.deepcopy.go, api/v1alpha1/zz_generated.openapi.go
Adds optional accountVerifierURL string field to RegistrationServiceConfig struct, with corresponding deepcopy and OpenAPI schema updates.
API Documentation
api/v1alpha1/docs/apiref.adoc
Documents the new accountVerifierURL field in RegistrationServiceConfig API reference.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

feature, documentation

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive PR description covers the main objective and addresses most required checks, but contains inconsistencies regarding the scope of changes. Clarify whether this is a new CRD or an extension of existing RegistrationServiceConfig; verify the host-operator PR link is correct and complete.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: add account verifier url config' directly describes the main change: adding a new configuration field for the account verifier URL to RegistrationServiceConfig.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot added feature New feature or request documentation Improvements or additions to documentation labels Apr 30, 2026
@mfrancisc mfrancisc merged commit cf8d9a0 into codeready-toolchain:master May 4, 2026
5 of 6 checks passed
@mfrancisc mfrancisc deleted the accountverifierconfig branch May 4, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants