Skip to content

Conversation

@KillianH
Copy link
Contributor

Fixed mistake on the "Per Page" translation
Updated Translation for "The :resource was updated!" translation

@hivokas
Copy link
Member

hivokas commented May 4, 2019

Should it be Par page : with : as a value?

@KillianH
Copy link
Contributor Author

KillianH commented May 5, 2019

I don't think so. There's no value in the original translation : "Per Page": "Per Page",

@hivokas
Copy link
Member

hivokas commented May 5, 2019

Then fix it please.

@KillianH
Copy link
Contributor Author

KillianH commented May 6, 2019

There's nothing to fix.
The original translation :
"Per Page:": "Par page :",
But the key is wrong so I've just fixed the key. The : in the translation is meant to be displayed.

@hivokas
Copy link
Member

hivokas commented May 6, 2019

I think it should not be displayed in the translation.
Because en.json contains "Per Page": "Per Page", without :

Removed the ":" character
@KillianH
Copy link
Contributor Author

KillianH commented May 6, 2019

Done. :)

@hivokas
Copy link
Member

hivokas commented May 6, 2019

Thanks

@hivokas hivokas merged commit 5adc812 into coderello:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants