Remove xnum conversions #203
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juntuu
force-pushed
the
remove-xnum
branch
2 times, most recently
from
4065eac to
abbaaef
Compare
Also use std::copy_n() instead of std::copy() in convert() Also also, I kind of understand, but wtf: std::numeric_limits<T>::min() and std::numeric_limits<T>::lowest() Now fixed behaviour with double (and bool)
The macro definition had parentheses, which made it work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues from #200
This removes the conversions from and to XNUM, and any cases triggering those in the tests #111
XNUM will still be present as building block for some of the other types
Identifying the conversions to and from XNUM was quite simple once those were removed from the code (#105 (comment)). I just put an
abort()where ever an XNUM conversion was, to disambiguate the test failure mode.