Convert isempty to C++ #208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now it's a direct copy of the original C code, with a nodiscard added to be on the safe side.
* Replace `A` with `array` * Use trailing return types
|
About the first point: Generally the functions often have commented the corresponding j phrase, if not Line 816 in de91efc |
|
That makes more sense than the |
codereport
requested changes
Mar 16, 2021
| verbs/vsb.c | ||
| verbs/vx.c | ||
| verbs/vz.c | ||
| verbs/monadic/isempty.cpp |
There was a problem hiding this comment.
Suggested change
| verbs/monadic/isempty.cpp | |
| verbs/monadic/is_empty.cpp |
| * @return boolean jtrue or jfalse | ||
| */ | ||
| [[nodiscard]] auto | ||
| jtisempty(J jt, array w) -> array { |
There was a problem hiding this comment.
Suggested change
| jtisempty(J jt, array w) -> array { | |
| is_empty(J jt, array w) -> array { |
juntuu
reviewed
Mar 16, 2021
| /** | ||
| * @brief `0 e. $` IsEmpty | ||
| * @param jt JST (J Syntax Tree) | ||
| * @param w Input aray |
There was a problem hiding this comment.
Just a typo
Suggested change
| * @param w Input aray | |
| * @param w Input array |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A branch I had around. It's pretty much a direct copy from the C function, with a few remarks:
jteps, which confuses me a lot. I'm not even sure why it does this.ANto something more descriptive, similar to theis_sparsefunction. However, this macro is used for assignment as well (seemake_array), so I just left the C macro here. I think the consistency here is more important.