Skip to content

Convert isempty to C++ #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Convert isempty to C++ #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cb6488
Move jtisempty to a cpp file
herwinw Feb 21, 2021
8ba4852
Restructure jtisempty to use preferred layout
herwinw Feb 21, 2021
6392a5a
Improve documentation for jtisempty
herwinw Feb 21, 2021
9bec2a8
Use is_sparse method
herwinw Feb 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions jsrc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ target_sources(j PRIVATE
verbs/vsb.c
verbs/vx.c
verbs/vz.c
verbs/monadic/isempty.cpp
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
verbs/monadic/isempty.cpp
verbs/monadic/is_empty.cpp

verbs/monadic/rank.cpp
verbs/monadic/same.cpp
verbs/monadic/shape.cpp
Expand Down
15 changes: 15 additions & 0 deletions jsrc/verbs/monadic/isempty.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#include "array.hpp"

/** @file */

/**
* @brief `0 e. $` IsEmpty
* @param jt JST (J Syntax Tree)
* @param w Input aray
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo

Suggested change
* @param w Input aray
* @param w Input array

* @return boolean jtrue or jfalse
*/
[[nodiscard]] auto
jtisempty(J jt, array w) -> array {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
jtisempty(J jt, array w) -> array {
is_empty(J jt, array w) -> array {

if (is_sparse(w)) return jteps(jt, num(0), shape(jt, w));
return AN(w) == 0 ? jtrue : jfalse;
}
6 changes: 0 additions & 6 deletions jsrc/verbs/v.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
/* Verbs */

#include "j.h"

A
jtisempty(J jt, A w) {
if ((AT(w) & SPARSE) != 0) return jteps(jt, num(0), shape(jt, w));
return AN(w) == 0 ? jtrue : jfalse;
} // 0 e. $
A
jtisnotempty(J jt, A w) {
if ((AT(w) & SPARSE) != 0) return jtnot(jt, jteps(jt, num(0), shape(jt, w)));
Expand Down