Removing more 32 bit support #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I feel these were improvement to evaluate, as they are: - no-ops - fit well with the surrounding pattern without feeling like magic numbers
codereport
approved these changes
Jan 26, 2021
Owner
codereport
left a comment
codereport
left a comment
There was a problem hiding this comment.
This is 🔥 (I will merge, g001 is flaky)
Collaborator
Author
|
I identified (at least one) flaky test case in the failing test g001.ijs I was able to reproduce this failure about 1/10 runs on the jconsole. p =: 0.5 * i. 10000 [ q =: 0.5 NB. setup, flaky lines below
((10000) 6!:2 'p + q') > 0.6 * (10000) 6!:2 'p +"0 _ q'
((10000) 6!:2 'p + q') > 0.6 * (10000) 6!:2 'p +"0 0 q'I found this https://code.jsoftware.com/wiki/Vocabulary/Foreigns#m6, which says the followin about the
So, it seems, the test is timing two different sentences over 10000 repetitions, and asserting something? about the difference. The tests have a comment saying
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing more non-64-bit support, with assumption of
BW == 64The
BW(bits in word) is still used in quite a many places. I mainly removed preprocessor conditionals and evaluated a couple expressions where it felt like an improvement.