[BUG] TypeError: string indices must be integers, not 'str'

[AlexanderShad]

Describe the bug
It crashes when I try to add it to favorites.

To Reproduce
Steps to reproduce the behavior:

1. Press 'Shift + O'
2. Select 'Radio Station 64'
3. Press 'Shift + 8' (to press *, laptop)
4. See error:

~ ❯ pyradio
Reading playlist...
Traceback (most recent call last):
File "/usr/bin/pyradio", line 9, in
sys.exit(shell())
^^^^^^^
File "/usr/lib/python3/site-packages/pyradio/main.py", line 1184, in shell
curses.wrapper(pyradio.setup)
File "/usr/lib64/python3.12/curses/init.py", line 94, in wrapper
return func(stdscr, *args, **kwds)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/site-packages/pyradio/radio.py", line 1341, in setup
self.run()
File "/usr/lib/python3/site-packages/pyradio/radio.py", line 2260, in run
ret = self.keypress(c) # Handle shortcut
^^^^^^^^^^^^^^^^
File "/usr/lib/python3/site-packages/pyradio/radio.py", line 9771, in keypress
ret, msg = self._cnf.add_to_favorites(self.stations[self.selection])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/site-packages/pyradio/config.py", line 208, in add_to_favorites
return self.favorites.add(an_item)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/site-packages/pyradio/config.py", line 4403, in add
ret = self._write_csv(items)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/site-packages/pyradio/config.py", line 4423, in _write_csv
ret = csv_out.write(items=items)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/site-packages/pyradio/common.py", line 868, in write
writter.writerow(self._format_playlist_row(a_station))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/site-packages/pyradio/common.py", line 834, in _format_playlist_row
this_row[Station.icon] = this_row[Station.icon]['image']
~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
TypeError: string indices must be integers, not 'str'

The error only occurs on this station.

Expected behavior
Add to favorites

System (please complete the following information):

• OS: ALT Linux (ALT Sisyphus)
• Python version: 3.12.11
• PyRadio Version: 0.9.3.11.19
• Player used: mpv

Additional context
the station continues playing after an error

[s-n-g]

On it!

[s-n-g]

Yeah, it is something about this specific station

Can you please provide its URL and Icon URL?
To get those, get into RadioBrowser, select the station in question and press "I" (capital "i")

[AlexanderShad]

Can you please provide its URL and Icon URL?

[AlexanderShad]

[s-n-g]

ok got it and fixed it in devel

If you want to get it fixed, just edit /usr/lib/python3/site-packages/pyradio/common.py (probably as root)
and make the following changes:

On line 834, change

            this_row[Station.icon] = this_row[Station.icon]['image']

to

            try:
                this_row[Station.icon] = this_row[Station.icon]['image']
            except TypeError:
                if isinstance(this_row[Station.icon], str):
                    this_row[Station.icon] =  this_row[Station.icon]

Just make sure that the white space at the beginning of every line comprises of space characters only, no TABs.

This is the difference

[s-n-g]

BTW, ALT Linux is such a nice distro!

Actually, i have made the changes on a Sisyphus VM (the screenshots are form there)!

I have had a problem once with epm not updating brave and got into your telegram channel; people were so nice to me (even though I do not speak any Russian) and got my problem fixed in no time.

I wish ALT got more recognition in Europe and worldwide!
Greetings from Greece!

[AlexanderShad]

to

            try:
                this_row[Station.icon] = this_row[Station.icon]['image']
            except TypeError:
                if isinstance(this_row[Station.icon], str):
                    this_row[Station.icon] =  this_row[Station.icon]

Hello )

Thank you, everything works now :)

I'll make a patch for the package now)

[AlexanderShad]

BTW, ALT Linux is such a nice distro!

Actually, i have made the changes on a Sisyphus VM (the screenshots are form there)!

I have had a problem once with epm not updating brave and got into your telegram channel; people were so nice to me (even though I do not speak any Russian) and got my problem fixed in no time.

I wish ALT got more recognition in Europe and worldwide! Greetings from Greece!

ALT Linux has a very friendly community :)