Moved micro-library to make it accessible from the addon namespace #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aries to the addon namespace
begedin
added a commit
that referenced
this pull request
Jul 16, 2015
…-ember-cli-pr Moved micro-library to make it accessible from the addon namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reworks how a micro-library is generated.
The end result is that, at build time,
library.jsgets renamed toaddon-name.jsand copied intoaddon/lib/addon-name.js. This makes it available for import from the addon namespace('addon-name/lib/addon-name'), where it was previously available for import from the app namespace('app-name/lib/addon-name').This is in compliance with the proposal I wrote (#30) as well as an Ember-CLI PR (coderly/ember-cli#1).