fix: parameters in the wrong order when delete duplicates session #15
Merged
riflowth merged 1 commit intocodern-org:mainfrom Jul 5, 2024
Merged
fix: parameters in the wrong order when delete duplicates session #15riflowth merged 1 commit intocodern-org:mainfrom
riflowth merged 1 commit intocodern-org:mainfrom
Conversation
…te session function
riflowth
approved these changes
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
variables were inserted in the wrong order in the delete duplicate session function
Description
What
The problem is that duplicate sessions are not deleted upon login.
Why
Parameters in the wrong order when authUsecase call DeleteDuplicates from sessionRepository
How
DeleteDuplicates Arrange parameters as (userId, ipAddress, userAgent)
But when called in authUsecase, arrange the parameters as (userId, userAgent, ipAddress)