fix(completion): keep autocomplete valid while typing - #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autocomplete stayed open while the user typed, but its edit snapshot remained pinned to the original buffer revision. Accepting the selection was therefore rejected as stale, and completion items without an LSP
textEditappended their label instead of replacing the typed prefix. Separately, bounded single-item popups reserved zero rows for their candidate and appeared empty.This change tracks normal typing and backspace as part of the active completion session, rebases safe LSP edit ranges, and continues rejecting unrelated buffer changes. Items without
textEditnow replace the active identifier prefix. Popup row accounting now keeps single candidates visible and positions scroll indicators on the actual border rows.How to Test
torch.manand wait formanual_seedto appear. Continue typingual, then press Enter. Expecttorch.manual_seedwith the popup closed and no duplicated text.Automated coverage includes continued typing, backspace, commit characters, LSP edit rebasing, stale-edit rejection, and bounded single-item rendering.
cargo test --all-featuresandcargo clippy --all-targets --all-features -- -D warningspass.