feat(completion): add compact async completion menu - #188
Merged
Conversation
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa95c39555
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing completion previously waited for both local and language-server results, then showed a large popup with an automatic preview. That made the menu feel heavier than Neovim's completion flow and left trigger characters such as
.filtering an obsolete completion session while typing through an open menu.This change makes completion immediate and unobtrusive:
Ctrl-n/Ctrl-por arrows to navigate,Tabto accept,Ctrl-eto dismiss, andEnterto insert a newlineEscexit to Normal mode, ignore late responses after dismissal, and start a fresh member-completion request on trigger characterscompletion.debounce_msconfigurableHow to Test
torch.manual_seed(...)line and add a blank line below it.to. Expect a compact completion menu to appear immediately with buffer candidates; LSP candidates should enrich the same menu without it jumping or reopening.rch.man. Expect a fresh member-completion menu containingmanual_seedand related matches, with the typed characters highlighted.Tab, then type(1337). Expecttorch.manual_seed(1337); pressEsconce and expect Normal mode.Ctrl-e, and wait for any outstanding LSP response. Expect the menu to remain dismissed. Reopen it and pressEnter; expect a newline rather than accepting the candidate.Automated coverage includes focused completion UI/lifecycle tests plus the full Rust suite and warning-as-error Clippy validation.