ci: make publish validate-specs step non-fatal (Part of #254)#310
Merged
Conversation
The publish workflow's `Validate specs` step runs `node bin/leanspec.js validate --warnings-only`, but the Rust CLI's `validate` command is not yet migrated to the adapter API and exits non-zero before the `--warnings-only` flag takes effect. That blocks every release. Treat the step as advisory (`continue-on-error: true`) so the workflow can proceed to publish. The flag name already signals the intent. Remove the override once `validate` is migrated. Part of #254 — unblocks the `leanspec@0.3.0` publish (run 26143212968). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adjusts the publish.yml CI workflow to avoid blocking releases when the Validate specs step exits non-zero despite being intended as informational (--warnings-only). This unblocks publishing leanspec@0.3.0 while the Rust validate command is still in transition.
Changes:
- Mark the
Validate specsstep as advisory by enablingcontinue-on-error: true.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblock the
leanspec@0.3.0publish (workflow run 26143212968 failed atValidate specs).The
Validate specsstep inpublish.ymlrunsnode bin/leanspec.js validate --warnings-only, but the Rust CLI'svalidatecommand isn't yet migrated to the adapter API and exits non-zero before the--warnings-onlyflag takes effect. That blocks every release.Treat the step as advisory (
continue-on-error: true). The flag name already signals it's informational. Drop the override oncevalidateis migrated to the adapter API.State of the partial publish:
@leanspec/{cli,mcp,http}-{platform}@0.3.0are already on npm.leanspec,@leanspec/mcp,@leanspec/http-server,@leanspec/uistill need to publish — this PR + a re-run ofpublish.ymlon main does that.Part of #254.
Test plan
gh workflow run publish.yml --ref main→ workflow completes →leanspec@0.3.0resolves onnpm view leanspec🤖 Generated with Claude Code