TWO_FACTOR_AUTHENTICATION_REQUIRED

[littleyoda]

Describe the bug

I am receiving an error regarding two-factor authentication.
Is there already a way to work around this error, or are there plans to implement two-factor authentication

Steps to reproduce the issue

``
from python_picnic_api2 import PicnicAPI
p = PicnicAPI("XXXX","YYYYYYY",'de');
p.get_deliveries()

{'error': {'code': 'TWO_FACTOR_AUTHENTICATION_REQUIRED', 'message': 'User must verify their second factor', 'details': {}}}
``

What did you expect to happen instead?

x

Python Version

3.13

[littleyoda]

The NPM-Implementition for picnic already contains function for 2FA:

https://github.com/MRVDH/picnic-api/blob/7dfbab91721b07651be8f4efa9e0c699f131ee58/src/index.ts#L105

[littleyoda]

Please find attached a first implementation for two-factor authentication.
Unfortunately, currently only available as a diff in a text file.

diff.txt

from python_picnic_api2 import PicnicAPI
p = PicnicAPI(user,pwd,'de');
print(F"2FA required: {p.is_2FA_Required()}")


print(p.generate_2fa_code())

if p.verify_2fa_code("294109"):
    print("Code ok")
else:
    print("Code wrong")

print(len(p.get_deliveries()))

print("Extracting Token for next login")
auth = p.session.auth_token
print(auth)

p = PicnicAPI(user,pwd,'de',auth_token = auth);

[codesalatdev]

Why did you close this issue? The integration tests started to fail today, so IMO this is still relevant?

[littleyoda]

Closing it was a mistake. I havn't the rights to reopen the issue.

[codesalatdev]

Ah I see, I will reopen and implement the function, thank you for the diff! :)

[codesalatdev]

Thanks for the report! The 2FA flow is added in version v1.3.3 https://pypi.org/project/python-picnic-api2/1.3.3/

[littleyoda]

Would you mind updating the readme file with a short information on how to use 2FA?

[codesalatdev]

Would you mind updating the readme file with a short information on how to use 2FA?

Updated: https://github.com/codesalatdev/python-picnic-api?tab=readme-ov-file#two-factor-authentication-2fa :)