refactor: remove fields from deleted sandboxes query and fix type errors #8829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
alexnm
approved these changes
Nov 14, 2025
tristandubbeld
deleted the
tristan/csb-708-remove-irrelevant-fields-for-deletedteamsandboxes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all the irrelevant fields from the
deletedTeamSandboxesquery by creating a separate fragment instead of using the generic dashboard sandbox fragment.After updating, some things broke and properties were no longer available (Typescript / the Sandbox component were expecting these). Components have been made typesafe and runtime safe to fix these issues.
✅ Tested on staging.