fix: Add custom retry delay support for startVM API calls#156
Merged
Conversation
Contributor
christianalfoni
commented
Aug 13, 2025
- Added retryDelay parameter to startVm method with default 200ms
- Sandbox creation: uses 200ms delay (preserves existing behavior)
- Sandbox restart: uses 1000ms delay for better stability
- Sandbox resume: uses 500ms delay for hibernated sandboxes
- Connection fallbacks: use 200ms delay for reconnection scenarios
- Added retryDelay parameter to startVm method with default 200ms - Sandbox creation: uses 200ms delay (preserves existing behavior) - Sandbox restart: uses 1000ms delay for better stability - Sandbox resume: uses 500ms delay for hibernated sandboxes - Connection fallbacks: use 200ms delay for reconnection scenarios 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| } | ||
|
|
||
| async startVm(id: string, data?: VmStartData["body"]) { | ||
| async startVm(id: string, data?: VmStartData["body"], retryDelay: number = 200) { |
Contributor
There was a problem hiding this comment.
With an optional optional parameter, I would rather introduce an options parameter. That way we don't pass undefined for data to most cases. Also clarifies intent when calling the function.
interface StartVmOptions {
data?: VmStartData['body'];
/**
* Milliseconds to wait before each retry.
* Defaults to 200 ms if omitted.
*/
retryDelay?: number;
}
startVm(id: string, options: StartVmOptions) {
const {
data,
retryDelay = 200
} = options
// etc.
}
mohamedveron
pushed a commit
that referenced
this pull request
Nov 20, 2025
* Add custom retry delay support for startVM API calls - Added retryDelay parameter to startVm method with default 200ms - Sandbox creation: uses 200ms delay (preserves existing behavior) - Sandbox restart: uses 1000ms delay for better stability - Sandbox resume: uses 500ms delay for hibernated sandboxes - Connection fallbacks: use 200ms delay for reconnection scenarios 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * add explicit retry in build * use merged options object instead --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.