fix: include response handling in retries and dispose clients in build to avoid reconnects#162
Merged
Conversation
…d to avoid reconnecst
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tristandubbeld
approved these changes
Aug 14, 2025
Comment on lines
+261
to
+262
| this.errorEmitter.dispose(); | ||
| this.messageEmitter.dispose(); |
Contributor
There was a problem hiding this comment.
These need to be disposed first, or is this just some sorting change?
Contributor
Author
There was a problem hiding this comment.
Do not think it actually fixes anything, but we want to "silence" the AgentConnection before we start cleaning up the rest. For example it could be a risk when disposing the underlying connection that an event sneaks through during the disposal, which we do not want 😄
mohamedveron
pushed a commit
that referenced
this pull request
Nov 20, 2025
…d to avoid reconnecst (#162)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.