update tests and gormStore #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmonader
force-pushed
the
master_ewf_gorm_store_tests
branch
from
0aaf607 to
fc9e268
Compare
xmonader
force-pushed
the
master_ewf_gorm_store_tests
branch
from
fc9e268 to
46dbe9c
Compare
AlaaElattar
reviewed
Jul 23, 2025
|
|
||
| // TestSQLiteStore_SaveAndLoad tests saving and loading a workflow in SQLiteStore. | ||
| func TestGormStore_SaveAndLoad(t *testing.T) { | ||
| dbFile := "test.db" |
Contributor
There was a problem hiding this comment.
please use temp dir for db testing file
| dbFile := "test.db" | ||
|
|
||
| db, err := gorm.Open(sqlite.Open(dbFile), &gorm.Config{}) | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
Why don't we use assert.NoError, what do u think ?
AlaaElattar
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor refactoring and adding a gorm store test
Checklist