Skip to content

Conversation

@zaelgohary
Copy link
Contributor

Changes

Replace global err boundary component w notification, remove unused files

Related Issues

Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add inline error handling. What we are doing here is to try to catch uncaught errors, instead on featch invoice we should have clear error fetching invoices failed due, or if the token is expired should redirect to the login page and only say session expired

@zaelgohary
Copy link
Contributor Author

I think we should add inline error handling. What we are doing here is to try to catch uncaught errors, instead on featch invoice we should have clear error fetching invoices failed due, or if the token is expired should redirect to the login page and only say session expired

This PR is for unblocking the UI and handling unhandled errors. For any other case, we can open an issue when we face specific errors, as determining unhandled errors will consume much time.

@0oM4R
Copy link
Contributor

0oM4R commented Aug 3, 2025

The blocking page is not exist anymore.. and lets agree to add error handlers whenever working on somthing related

@zaelgohary zaelgohary merged commit b3ae314 into master Aug 4, 2025
@rawdaGastan rawdaGastan deleted the master_error_handler branch September 29, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants