Fix change pass form validation #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0oM4R
reviewed
Aug 7, 2025
Contributor
0oM4R
left a comment
0oM4R
left a comment
There was a problem hiding this comment.
can we reduce the space before the button here to be like this maybe?
also validating the confirm password without interacting the field is not the best UX imo
Screen.Recording.2025-08-07.at.11.00.25.AM.mov
Contributor
Author
Done
I had to trigger validation for both fields on input to make sure form is always valid and button has the correct state even after the form is being valid then unvalid. |
0oM4R
approved these changes
Aug 10, 2025
Contributor
0oM4R
left a comment
0oM4R
left a comment
There was a problem hiding this comment.
we may handle the validation flow after adding the input form validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related Issues