Skip to content

Conversation

@AlaaElattar
Copy link
Contributor

@AlaaElattar AlaaElattar commented Jul 13, 2025

Description

  • Integration Tests for user, admin and invoice handlers.

Changes

  • Fixed the test workflow

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstring

@AlaaElattar AlaaElattar marked this pull request as draft July 13, 2025 09:12
@AlaaElattar AlaaElattar changed the base branch from master to master_ewf July 13, 2025 09:13
@AlaaElattar AlaaElattar marked this pull request as ready for review July 13, 2025 14:33
@AlaaElattar AlaaElattar changed the title Master user tests user tests Jul 13, 2025
@AlaaElattar AlaaElattar requested a review from rawdaGastan July 13, 2025 14:36
Copy link
Contributor

@rawdaGastan rawdaGastan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests workflow fails :D

- /root/.ssh:/root/.ssh:ro
command: ["/kubecloud", "--config", "/app/configs.json"]

backend-test:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why testing in docker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The backend no longer run locally on mac os, so i run tests from inside the container.

@AlaaElattar AlaaElattar marked this pull request as draft July 14, 2025 15:37
@AlaaElattar AlaaElattar marked this pull request as ready for review July 15, 2025 10:38
@rawdaGastan
Copy link
Contributor

make sure test workflow passes

@AlaaElattar AlaaElattar marked this pull request as ready for review August 5, 2025 09:02
@AlaaElattar AlaaElattar marked this pull request as draft August 5, 2025 10:28
@AlaaElattar AlaaElattar marked this pull request as ready for review August 5, 2025 11:34
@AlaaElattar AlaaElattar changed the title user tests Integration Tests Aug 6, 2025
@AlaaElattar AlaaElattar merged commit 9269d41 into master Aug 7, 2025
@AlaaElattar AlaaElattar deleted the master_user_tests branch August 7, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants