Master ewf deployer #95

xmonader · 2025-07-20T09:00:10Z

Description

Describe the changes introduced by this PR and what does it affect

Changes

List of changes this PR includes

Related Issues

List of related issues

Checklist

Tests included
Build pass
Documentation
Code format and docstring

xmonader · 2025-07-20T09:14:14Z

backend/app/app.go

-		// deployer.WithSubstrateURL("wss://tfchain.dev.grid.tf/ws"),
-		// deployer.WithProxyURL("https://gridproxy.dev.grid.tf"),
-		// deployer.WithRelayURL("wss://relay.dev.grid.tf"),
+		deployer.WithSubstrateURL("wss://tfchain.dev.grid.tf/ws"),


Remember to remove after testing

xmonader · 2025-07-20T09:15:59Z

backend/kubedeployer/client_test.go

+	ctx := context.Background()
+
+	cluster := Cluster{
+		Name:  "jrk8s12",


definitely not jerk xD

i meant jarvis-kubernetes-# :D
chaned

xmonader · 2025-07-20T09:17:06Z

backend/kubedeployer/client.go

+	gridNet      string
+	mnemonic     string
+	masterPubKey string
+	UserID       string


Why part of the client while that can get passed as an argument?

just easier to set/get, used in multiple functions

- move the cancel/remove code from handler to the pkg - modify to client struct - introduce naming convension - better testing

…enough

…addition

…ated tests

…or handling

…d clarity

AlaaElattar · 2025-07-21T07:59:45Z

backend/internal/activities/deployer_activities.go

+	},
+}
+
+func registerDeploymentActivities(engine *ewf.Engine) {


Please make all strings constants to be used anywhere

AlaaElattar · 2025-07-21T08:52:43Z

backend/app/deployment_handler.go

-	if err != nil {
-		log.Error().Err(err).Str("user_id", userIDStr).Msg("Failed to parse user ID")
-		c.JSON(http.StatusInternalServerError, gin.H{"error": "failed to parse user ID"})
+	var cluster kubedeployer.Cluster


I think this should be the first check in function

AlaaElattar · 2025-07-21T08:54:13Z

backend/app/deployment_handler.go

+		TaskID:    wf.UUID,
+		Status:    string(wf.Status),
+		Message:   "Node addition workflow started successfully",
+		CreatedAt: wf.CreatedAt,


why u are returning CreatedAt ?

AlaaElattar · 2025-07-21T09:01:21Z

backend/app/deployment_handler.go

-		c.JSON(http.StatusInternalServerError, gin.H{"error": "failed to update deployment in database"})
+	wf, err := h.ewfEngine.NewWorkflow("remove_node")
+	if err != nil {
+		c.JSON(http.StatusInternalServerError, gin.H{"error": "Failed to create workflow"})


There's already an InternalServerError(c) function defined to be used.

AlaaElattar · 2025-07-21T09:03:02Z

backend/app/deployment_handler.go

-		"deployment_name": deploymentName,
-		"node_name":       nodeName,
+	c.JSON(http.StatusOK, Response{
+		TaskID:    wf.UUID,


its not a task id, it is a workflow id.

Also there's endpoint for checking the workflow status by its id. u don't have to return status here

AlaaElattar · 2025-07-21T09:53:21Z

backend/internal/activities/deployer_activities.go

+			return fmt.Errorf("failed to assign node IPs for added cluster: %w", err)
+		}
+
+		for idx, node := range addedCluster.Nodes {


what if smth failed in middle what will happen when workflow engine retries? will it start the loop from beginning ?

AlaaElattar · 2025-07-21T10:24:29Z

backend/cmd/root.go


 	// === Workflow DB File ===
 	if err := bindStringFlag(rootCmd, "workflow_db_file", "", "Workflow database file path"); err != nil {
 		return fmt.Errorf("failed to bind workflow_db_file flag: %w", err)


u deleted workflow_db_file from Configuration struct, u should delete it from here too.

AlaaElattar · 2025-07-21T10:29:30Z

backend/internal/activities/deployer_activities.go

+	}
+	engine.RegisterTemplate("remove_cluster", &deleteWFTemplate)
+
+	// addNodeWFTemplate := baseWFTemplate


please remove commented code

AlaaElattar · 2025-07-21T10:35:32Z

backend/kubedeployer/client.go

+	var nodeToRemove *Node
+	var nodeIndex int
+	for i, node := range cluster.Nodes {
+		fmt.Println("full node name:", fullNodeName)


why fmt ? the app already uses logger

…ment activities

xmonader · 2025-07-21T13:41:06Z

backend/app/deployment_handler.go

-	log.Debug().Str("user_id", userIDStr).Str("deployment_name", deploymentName).Msg("Starting deployment deletion")

-	cluster, err := h.db.GetClusterByName(userIDStr, deploymentName)
+	// TODO: load it at startup instead


Fix the todo please

Omarabdul3ziz

eh el3zma de

xmonader commented Jul 20, 2025

View reviewed changes

Omarabdul3ziz added 14 commits July 21, 2025 01:04

refactor kubedeployer:

a849012

- move the cancel/remove code from handler to the pkg - modify to client struct - introduce naming convension - better testing

refactor: single network on the same node for mulitple deployment is …

86383fa

…enough

feat: implement rollback functionality for cluster creation and node …

96a2bd4

…addition

refactor: simplify project name generation and improve IP tracking logic

28288ef

refactor: unify network handling in cluster operations and update rel…

95de787

…ated tests

feat: add deployment activities registration to workflow engine

e84f62a

feat: refactor cluster management

9464d58

fix: update K3S_DATA_DIR to correct mount path

811a898

refactor: update deployment handlers to use new workflows

d14f46d

feat: enhance deployment functions

32d54b3

feat: add notify/store activities to deployment workflows

735d49f

refactor: streamline client management and enhance workflow templates

466a8a7

feat: enhance the singular node deployment

8a87abf

feat: implement dynamic deployment workflow templates and enhance err…

fe3260c

…or handling

Omarabdul3ziz force-pushed the master_ewf_deployer branch from 301894b to fe3260c Compare July 20, 2025 22:13

Omarabdul3ziz added 2 commits July 21, 2025 02:22

feat: update deployment tests and refactor client methods for improve…

e970767

…d clarity

refactor: use same db for workflows

3538c09

AlaaElattar reviewed Jul 21, 2025

View reviewed changes

refactor: reorganize deployment logic and remove deprecated code

7b9dcb2

AlaaElattar reviewed Jul 21, 2025

View reviewed changes

Omarabdul3ziz added 3 commits July 21, 2025 15:21

refactor: enhance add/remove nodes

511993f

cleanup: cleanup logs and remove duplicated code

8d3cbf1

refactor: update response structure and workflow constants for deploy…

d016242

…ment activities

xmonader commented Jul 21, 2025

View reviewed changes

Omarabdul3ziz added 2 commits July 21, 2025 17:03

refactor: load SSH public key at startup and update handler to use it

a7eb098

remove the global ip tracker, load usedIps from grid directly

050a41b

Omarabdul3ziz added 2 commits July 21, 2025 17:56

refactor: pass config as argument instead of a client state

013fe45

refactor: enhance error messages for already deployed network and node

43b42ac

Omarabdul3ziz approved these changes Jul 21, 2025

View reviewed changes

xmonader merged commit 9be6159 into master_ewf Jul 21, 2025
2 checks passed

xmonader deleted the master_ewf_deployer branch July 22, 2025 16:44

Master ewf deployer #95

Master ewf deployer #95

Uh oh!

Conversation

xmonader commented Jul 20, 2025

Description

Changes

Related Issues

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xmonader Jul 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlaaElattar Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Omarabdul3ziz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xmonader Jul 20, 2025 •

edited

Loading

AlaaElattar Jul 21, 2025 •

edited

Loading