Skip to content

Conversation

@gabrielmfern
Copy link
Collaborator

This is meant to address resend/react-email#1632.

The issue was that the escapeQuotes was assuming that the received value
would always be a string, whereas it could be a number based on how React
treats values for styles. So even something like fontWeight: 600 is a valid
style while still not being converted into font-weight: 600px when converted.

The fix was very simple, only checking for quotes to escape if the passed in value
is actually a string.

@lordelogos lordelogos merged commit 2b5b1b8 into codeskills-dev:master Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants