fix: escape quotes failing when value is not a string #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to address resend/react-email#1632.
The issue was that the
escapeQuoteswas assuming that the received valuewould always be a string, whereas it could be a number based on how React
treats values for styles. So even something like
fontWeight: 600is a validstyle while still not being converted into
font-weight: 600pxwhen converted.The fix was very simple, only checking for quotes to escape if the passed in value
is actually a string.