feat(bundles): split into slashed-essential.css + slashed-full.css (v0.6.7.0)#30
Conversation
…0.6.7.0) Two-tier bundle strategy: - slashed-essential.css: tokens + core + utilities (lean default, replaces old slashed-full.css content) - slashed-full.css: everything — essential + components + visual utilities + animations + viewport utilities (single-link convenience bundle) Both are generated by bin/build-bundle.sh and checked in CI. slashed-experimental.css and tokens-legacy.css remain always-opt-in. Consumers who want the pre-0.6.7.0 lean bundle: replace slashed-full.css with slashed-essential.css — byte-for-byte identical content. https://claude.ai/code/session_015PtCjooV5PBX9a26f3UEF1
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThis PR introduces a two-tier CSS bundle model (v0.6.7.0): ChangesTwo-Tier Bundle System
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Build as build-bundle.sh
participant Repo as Repository (fs)
participant CI as GitHub Actions
Dev->>Build: run build-bundle.sh
Build->>Repo: write css/slashed-essential.css
Build->>Repo: write css/slashed-full.css
CI->>Repo: checkout + run "Regenerate bundles" step (build-bundle.sh)
CI->>Repo: diff css/slashed-essential.css & css/slashed-full.css
alt diffs found
CI->>Dev: "One or both bundles are out of date." (fail)
else no diffs
CI->>Dev: pass
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Microsoft Presidio Analyzer (2.2.362)ROADMAP.mdMicrosoft Presidio Analyzer failed to scan this file Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
css/slashed-utilities.css (1)
2-12:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winBundle guidance in this header appears out of date for v0.6.7.0.
This file still says viewport utilities are not included in
slashed-full.css, which conflicts with the two-tier bundle contract described in this PR.Suggested text update
- They live in slashed-utilities-viewport.css — not included in - slashed-full.css. Load that file separately when needed. + They live in slashed-utilities-viewport.css and are included in + slashed-full.css. Load that file separately when using + slashed-essential.css.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@css/slashed-utilities.css` around lines 2 - 12, Update the header comment in the slashed-utilities.css top block (the v0.6.7.0 banner) to reflect the new two-tier bundle contract: remove or change the sentence that says viewport utilities live in slashed-utilities-viewport.css and are not included in slashed-full.css, and instead state that viewport breakpoint utilities are now included in slashed-full.css (or clearly document when slashed-utilities-viewport.css should be loaded separately). Keep the version string (v0.6.7.0) and the references to tokens-default.css + slashed-core.css (or slashed-full.css), but make the wording consistent with the PR contract so readers aren’t misled.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ROADMAP.md`:
- Line 4: Update the ROADMAP.md mention of the single essential bundle to
reflect the new bundle split: replace references that call only
"slashed-full.css" as the essential bundle with a clear distinction between
"slashed-essential.css" (the essential bundle) and "slashed-full.css" (the full
bundle), and adjust any explanatory text so readers understand which bundle is
required for minimal functionality versus the full feature set; ensure
occurrences of "slashed-full.css" in the roadmap are updated to either
"slashed-essential.css" where minimal/essential is intended or left as
"slashed-full.css" where full styling is meant.
---
Outside diff comments:
In `@css/slashed-utilities.css`:
- Around line 2-12: Update the header comment in the slashed-utilities.css top
block (the v0.6.7.0 banner) to reflect the new two-tier bundle contract: remove
or change the sentence that says viewport utilities live in
slashed-utilities-viewport.css and are not included in slashed-full.css, and
instead state that viewport breakpoint utilities are now included in
slashed-full.css (or clearly document when slashed-utilities-viewport.css should
be loaded separately). Keep the version string (v0.6.7.0) and the references to
tokens-default.css + slashed-core.css (or slashed-full.css), but make the
wording consistent with the PR contract so readers aren’t misled.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 18a04f1b-8389-4882-9534-6537e54d1711
📒 Files selected for processing (22)
.github/workflows/bundle-check.ymlCHANGELOG.mdCLAUDE.mdCONTRIBUTING.mdREADME.mdROADMAP.mdbin/build-bundle.shbin/bump-version.shbin/check-cheatsheet-sync.shbin/setup-hooks.shcheatsheet.htmlcss/slashed-animations.csscss/slashed-components.csscss/slashed-core.csscss/slashed-essential.csscss/slashed-experimental.csscss/slashed-full.csscss/slashed-utilities-visual.csscss/slashed-utilities.csscss/tokens-default.csscss/tokens-legacy.cssdocs/INSTALLATION.md
…tract - bin/bump-version.sh: add slashed-utilities-viewport.css to anchor list (was missing — that's why the file stayed at v0.6.6.0 after the bump). Also bumped 0.6.5.0 example references to 0.6.7.0. - css/slashed-utilities-viewport.css: bump banner to v0.6.7.0 and rewrite load-order / customisation guidance for the two-tier bundle model. - css/slashed-utilities.css: rewrite the viewport-utilities pointer comments to reflect that they ship inside slashed-full.css and are opt-in only when using slashed-essential.css. - ROADMAP.md: refer to slashed-essential.css (not slashed-full.css) for the lean bundle in the post-0.6.0.0 note and the breakpoints scope note. - docs/UTILITIES.md: rewrite source-of-truth note, container/viewport responsive variants, customisation, and visual-utilities pointers for the new bundle contract. - Bundles regenerated. https://claude.ai/code/session_015PtCjooV5PBX9a26f3UEF1
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Two-tier bundle strategy:
old slashed-full.css content)
animations + viewport utilities (single-link convenience bundle)
Both are generated by bin/build-bundle.sh and checked in CI.
slashed-experimental.css and tokens-legacy.css remain always-opt-in.
Consumers who want the pre-0.6.7.0 lean bundle: replace slashed-full.css
with slashed-essential.css — byte-for-byte identical content.
https://claude.ai/code/session_015PtCjooV5PBX9a26f3UEF1
Summary by CodeRabbit
New Features
Documentation
Chores