Skip to content

fix: object cache issues on settings page #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

fix: object cache issues on settings page #290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7908f8b
fix: cache issues on settings page
louiswol94 Nov 5, 2025
e30a6fd
Update settings.php
louiswol94 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/php/settings/settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
use Code_Snippets\Welcome_API;
use function Code_Snippets\clean_snippets_cache;
use function Code_Snippets\code_snippets;
use const Code_Snippets\CACHE_GROUP;

const CACHE_KEY = 'code_snippets_settings';
const OPTION_GROUP = 'code-snippets';
Expand Down Expand Up @@ -79,7 +80,7 @@ function are_settings_unified(): bool {
* @return array<string, array<string, mixed>>
*/
function get_settings_values(): array {
$settings = wp_cache_get( CACHE_KEY );
$settings = wp_cache_get( CACHE_KEY, CACHE_GROUP );
if ( $settings ) {
return $settings;
}
Expand All @@ -93,7 +94,7 @@ function get_settings_values(): array {
}
}

wp_cache_set( CACHE_KEY, $settings );
wp_cache_set( CACHE_KEY, $settings, CACHE_GROUP );
return $settings;
}

Expand Down Expand Up @@ -125,7 +126,7 @@ function update_setting( string $section, string $field, $new_value ): bool {

$settings[ $section ][ $field ] = $new_value;

wp_cache_set( CACHE_KEY, $settings );
wp_cache_set( CACHE_KEY, $settings, CACHE_GROUP );
return update_self_option( are_settings_unified(), OPTION_NAME, $settings );
}

Expand Down Expand Up @@ -306,7 +307,7 @@ function process_settings_actions( array $input ): ?array {
* @return array<string, array<string, mixed>> The validated settings.
*/
function sanitize_settings( array $input ): array {
wp_cache_delete( CACHE_KEY );
wp_cache_delete( CACHE_KEY, CACHE_GROUP );
$result = process_settings_actions( $input );

if ( ! is_null( $result ) ) {
Expand Down