fix: beta issues by imantsk · Pull Request #337 · codesnippetspro/code-snippets

imantsk · 2026-03-10T17:29:00Z

Summary

This branch fixes the beta issues reported for Code Snippets and includes a set of follow-up admin usability improvements that were discovered while validating those fixes.

Included Fixes

Snippet editor and snippet data

Restored snippet description rendering in both:
- the snippet editor view
- the All Snippets table
Fixed Save and Activate for brand new snippets so activation works reliably on the first save.
Fixed activation failure handling for snippets with PHP errors:
- activation does not silently fail
- the error notice includes the single-line PHP error message and an expandable stack trace
Added shared notice styling for traced activation errors, including horizontal scrolling for long stack traces.
Removed the cs-back back link from the editor.

Admin navigation fixes

Fixed admin bar snippet links to use the correct id query parameter.
Changed the Edit Snippet sidebar item so it no longer navigates away from the current page:
- clicking it focuses the CodeMirror editor

Export and download fixes

Fixed bulk export so selected snippets can be exported again as JSON for re-import.
Kept Export and Download as separate actions:
- Export produces importable JSON
- Download produces raw snippet files
Added bulk-only Download action for snippet code:
- single selection downloads as an individual file based on snippet type
- multiple selections download as a ZIP archive when ZipArchive is available
Adjusted the bulk action UI so:
- Apply is disabled by default and while Bulk actions is selected
- Apply enables when a real action is selected

Flat Files compatibility

Fixed the Flat Files + LiteSpeed Cache fatal by preventing early bootstrap code from calling unavailable WordPress functions.

Manage Screen Improvements

Screen Options

Added Screen Options support for choosing visible columns on the All Snippets table.
Added a Table Options section for snippets table behavior with a toggle for truncating long row values.
Restricted Screen Options so:
- snippets view shows Table Options, Columns, and Pagination
- cloud-community shows only Pagination

Table behavior and markup

Fixed sortable header markup/classes to match WordPress core sorted column behavior.

Community Cloud pagination

Applied the Screen Options pagination setting to Community Cloud requests passing per_page through the local REST layer and outbound cloud API request.
Capped cloud per_page at 100 even if the user’s screen option is higher (avoids api error messages)

…reen options

…reen options handling

…reen options tests

sheabunge · 2026-03-11T07:36:59Z

src/js/components/common/ListTable/ListTable.tsx

+const getVisibleSelected = <T, K extends Key>(visibleItems: T[], getKey: (item: T) => K, selected: Set<K>): Set<K> =>
+	new Set(visibleItems.map(getKey).filter(key => selected.has(key)))
+
+const buildTableNavProps = <K extends Key>({


What's the purpose of this function? It seems to just be passing values through directly.

Removed the redundant pass-through helper and inlined the props construction.
Commit: 72b6b0db1

sheabunge · 2026-03-11T07:37:22Z

src/js/components/common/ListTable/ListTable.tsx

-			<TableNav which="bottom" {...tableNavProps} />
-		</>
-	)
+	return <ListTableMarkup


What's the benefit in taking this out separately?

removed the unnecessary extraction
Commit: 72b6b0db1

sheabunge · 2026-03-11T07:37:47Z

src/js/components/common/ListTable/TableHeadings.tsx

 		? 'asc' === sortDirection ? 'desc' : 'asc'
 		: column.defaultSortDirection ?? 'asc'
+	const classDirection = isCurrent ? sortDirection : 'asc' === nextSortDirection ? 'desc' : 'asc'
+	const ariaSort = isCurrent ? 'asc' === sortDirection ? 'ascending' : 'descending' : undefined


This can be inlined.

fixed
Commit: b8e442ad5

sheabunge · 2026-03-11T07:38:05Z

src/js/components/common/ListTable/TableItems.tsx


 const TableCell = <T, >({ item, column }: TableCellProps<T>) => {
-	const className = `${column.id}-column column-${column.id}`
+	const className = [ `${column.id}-column`, `column-${column.id}`, column.isHidden ? 'hidden' : '' ]


Please use the classnames.classnames module for this sort of thing.

fixed
Commit: 19ed1ea50

sheabunge · 2026-03-11T07:38:47Z

src/js/components/common/ListTable/TableNav.tsx

 			id={`bulk-action-selector-${which}`}
+			value={selectedActionName}
 			onChange={event => {
+				setSelectedActionName(event.target.value)


It's a bit of a shame to lose the typing here – what's the benefit in this change vs what we are losing?

fixed
Commit: ecfa584fe

sheabunge · 2026-03-11T07:57:19Z

src/php/Admin/Menus/Manage_Menu.php

 		return 'snippets_per_page' === $option ? $value : $status;
 	}
+
+	/**


This should be handled through the REST API, IMO.

#337 (comment)

sheabunge · 2026-03-11T07:57:46Z

src/php/Flat_Files/Snippet_Files.php

 	 * @return void
 	 */
 	public function sync_active_shared_network_snippets_add( $option, $value ): void {
-		if ( 'active_shared_network_snippets' !== $option ) {


Rewrote the option handler with a clearer early-return guard style.
Commit: 0c70958f4

sheabunge · 2026-03-11T07:59:03Z

src/php/Flat_Files/Snippet_Files.php

 	 */
 	public static function get_hashed_table_name( string $table ): string {
-		return wp_hash( $table );
+		return function_exists( 'wp_hash' ) ? wp_hash( $table ) : md5( $table );


wp_hash has been around since 2.0.3 – do we really need to assume it may not exist? Or is it a contextual fill-in?

it’s because of load order and namespacing, not as much about WP version support.
Plugin like LiteSpeed can trigger this path before pluggable functions are loaded, and in a namespace we must call \wp_hash. The guard/fallback is to avoid a fatal during early bootstrap; once WP is fully loaded we’ll use \wp_hash as normal.
Commit: b9ca72a66

sheabunge · 2026-03-11T08:00:26Z

src/php/Model/Model.php

 	 */
 	protected static function resolve_field_name( string $field ): string {
-		return self::$field_aliases[ $field ] ?? $field;
+		return static::$field_aliases[ $field ] ?? $field;


Great pick-up, thanks.

sheabunge · 2026-03-11T08:02:03Z

src/php/snippet-ops.php

@@ -755,6 +763,8 @@ function execute_snippet( string $code, int $id = 0, bool $force = false ) {
 		$result = eval( $code );
 	} catch ( ParseError $parse_error ) {


We might as well remove the ParseError catch if we're going to be catching Throwable anyway.

Removed redundant ParseError catches and the unused import.
Commit: c11d81954

ref: #337 (comment) ref: #337 (comment)

ref: #337 (comment)

ref: #337 (comment) ref: #337 (comment) ref: #337 (comment)

ref: #337 (comment)

imantsk · 2026-03-16T08:31:29Z

@sheabunge
ref: #337 (comment)
ref: #337 (comment)

REST downloads are possible (set Content-Disposition: attachment and return raw bytes), but in WP they tend to be more fragile in practice: REST is JSON-first, fetch won’t trigger a native browser download without extra client-side Blob/link work, and large ZIP streaming can run into buffering/memory edge cases. For Screen Options specifically, if we want the controls to live in WP’s native Screen Options flyout (columns/per-page), we’re constrained to core’s PHP hooks (add_screen_option, screen_settings, set-screen-option) and then have React consume/apply the persisted values; moving the UI itself “into React” would mean building and maintaining a separate custom settings UI rather than using native Screen Options.

imantsk added 30 commits March 10, 2026 12:21

fix: restore snippet description hydration

7ad52a2

fix: activate new snippets on first save

25c28e9

fix: surface activation errors after save

3bbb18e

fix: restore bulk snippet export

9c93621

fix: correct admin bar edit links

0aec73f

fix: remove the edit snippet submenu

5501b7c

fix: avoid flat files option hook fatals

09282f7

fix: focus editor from edit menu item

98db56c

fix: restore pointer cursor on edit menu item

df40f28

fix: move stack trace notices above snippet form

044f710

fix: polish traced activation notices

f346bf4

chore: centralize notice styling

a407445

fix: update notice styling and add horizontal scroll hint

7d3ec10

fix: emphasize activation failure message

5560814

fix: remove editor back link

ae1f96a

feat: add snippet table column screen options

09e69d1

fix: left align modified column content

746ecea

fix: match wordpress sorted header classes

c25dde9

feat: add snippets table truncation screen option

a57c81d

fix: limit snippets table truncation to content columns

fb7d64c

fix: scope snippets table truncation to name and description

9e35d19

fix: correct snippets table name truncation

9b67988

fix: refactor cloud search form styles and remove redundant code

e57ed0e

fix: adjust max-inline-size for snippet name and description columns

78b870e

fix: remove description for truncation option in manage menu

bd05150

fix: update legend text case in table options fieldset

c229fa5

fix: apply snippets pagination to cloud search

228c25c

fix: cap cloud search page size

ffac81c

fix: enhance manage menu to handle cloud community view and update sc…

b5f3ad2

…reen options

fix: enhance manage menu tests for cloud community view and update sc…

7c4fd4d

…reen options handling

imantsk added 10 commits March 10, 2026 22:30

fix: add bulk export test for scoped snippet selection and enhance sc…

e1ac6ea

…reen options tests

fix: hide edit menu item outside editor

8784a8c

fix: use current screen for edit menu visibility

1ffaf0d

fix: restore cloud pagination screen options

09bd77a

fix: scope snippet helper list lookups

53577f2

fix: normalize validator exceptions for pluggable declarations

640a7d5

fix: avoid mbstring dependency for downloads

397d49e

fix: remove html from activation error notice

20afd76

fix: align snippet export schema and bulk export fields

22caa81

fix: bold activation error message without translating it

3a36282

imantsk added the build Adding this label will trigger the zip build action label Mar 11, 2026

sheabunge reviewed Mar 11, 2026

View reviewed changes

sheabunge and others added 15 commits March 11, 2026 20:01

Add playwright-report to eslint ignores.

8200a7e

fix: expand practical reviewer checks in code review instructions

323d791

fix: simplify list table nav props

72b6b0d

ref: #337 (comment) ref: #337 (comment)

fix: inline sortable list table headings

b8e442a

ref: #337 (comment)

fix: use classnames for list table cell classes

19ed1ea

ref: #337 (comment)

fix: tighten list table bulk actions typing

ecfa584

ref: #337 (comment) ref: #337 (comment) ref: #337 (comment)

fix: simplify focus editor shortcut hook

14d0ba5

ref: #337 (comment)

fix: use undefined for optional edit menu attrs

92c7e01

ref: #337 (comment)

fix: switch activation error notice to jsx

3c7afe1

ref: #337 (comment)

fix: simplify export default value checks

c511d32

ref: #337 (comment)

fix: add filter for default snippets per page

6f38fe3

ref: #337 (comment)

fix: clarify active shared network sync guard

0c70958

ref: #337 (comment)

fix: call global wp_hash with early fallback

b9ca72a

ref: #337 (comment)

fix: remove redundant ParseError catch blocks

c11d819

ref: #337 (comment)

chore: align phpunit test docs with wpcs

2e57771

ref: #337 (comment)

imantsk added build Adding this label will trigger the zip build action and removed build Adding this label will trigger the zip build action labels Mar 16, 2026

		@@ -755,6 +763,8 @@ function execute_snippet( string $code, int $id = 0, bool $force = false ) {
		$result = eval( $code );
		} catch ( ParseError $parse_error ) {

Conversation

imantsk commented Mar 10, 2026

Summary

Included Fixes

Snippet editor and snippet data

Admin navigation fixes

Export and download fixes

Flat Files compatibility

Manage Screen Improvements

Screen Options

Table behavior and markup

Community Cloud pagination

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imantsk commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants