Fix: accessible import snippets tabs#344
Merged
Conversation
louiswol94
approved these changes
Apr 10, 2026
imantsk
approved these changes
Apr 14, 2026
Member
|
@rami-elementor The use of placeholder links in this instance was intentional – rather than replacing with buttons, I'd prefer to introduce routing and have the tabs link to actual URLs. |
Contributor
Author
|
@sheabunge For now I prefer to leave it like that. When you decide to introduce routing and have the tabs links as actual URLs, just refactor the code. |
Member
|
@rami-elementor my only issue with that is now they are less apparent to someone checking and refactoring – a link to I'll just go through and add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
<a href="#">with<button>to improve semantics. Links are used only for linking to other pages. In this case, clicking the element changes the tab. So, it's not a link.