fix: surface missing bugatti.config.toml instead of silent default (#45)#46
Merged
Conversation
Add a `--config <PATH>` flag that hard-errors when the file is missing, and promote the cwd fallback log from INFO to a stderr WARNING so the silent "using defaults" behavior is visible in the terminal and run report rather than buried in diagnostics/harness_trace.jsonl. Bumps version to 0.4.2.
The previous commit accidentally swept in pre-existing refactors that route provider initialization through bugatti::provider::initialize_session, which doesn't yet exist on main. Restore ClaudeCodeAdapter::initialize so the crate builds again and CI clippy passes.
The CI runner's clippy (1.95) treats collapsible_match as an error via -D warnings, whereas 1.94 let it through. Fold the `if self.verbose` checks for the "tool_use" and "thinking" arms into match guards so CI builds cleanly without pinning the toolchain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--config <PATH>flag onbugatti test; a missing file is a hard error (no silent fallback).WARNING:so the behavior is visible in the terminal instead of only indiagnostics/harness_trace.jsonl.0.4.1→0.4.2.Fixes #45.
Behavior
bugatti test …withbugatti.config.tomlin cwdbugatti test …with no config in cwdWARNING: no bugatti.config.toml found in <cwd> — running with defaults.to stderr, then runs with defaultsbugatti test --config path/to/config.toml …Test plan
cargo clippy -- -D warningscleancargo test— all 217 tests pass (3 new unit tests forload_config_from_file: arbitrary filename, missing-file hard error, invalid TOML)bugatti test --helplists--config <PATH>bugatti test <file>from a directory withoutbugatti.config.tomland confirm the warning hits stderrbugatti test --config nope.toml <file>and confirm exit code 2 with a clear error