Skip to content

Use squeeze-blank-lines script#787

Merged
mernst merged 2 commits intocodespecs:masterfrom
mernst:squeezeblanklines
May 9, 2026
Merged

Use squeeze-blank-lines script#787
mernst merged 2 commits intocodespecs:masterfrom
mernst:squeezeblanklines

Conversation

@mernst
Copy link
Copy Markdown
Member

@mernst mernst commented May 9, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 9, 2026

Review Change Stack

Warning

Rate limit exceeded

@mernst has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 47 minutes and 1 second before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ffe7eb80-7239-439c-8143-c71931f7f1d4

📥 Commits

Reviewing files that changed from the base of the PR and between df2db44 and 62c3e1b.

📒 Files selected for processing (2)
  • .azure/Makefile
  • .circleci/Makefile
📝 Walkthrough

Walkthrough

This PR consolidates the plume-scripts build dependency into a centralized, auto-cloning variable and renames related Make targets. The .azure/Makefile now defines PLUME_SCRIPTS (defaulting to ../.utils/plume-scripts), cloning the repository if missing, and delegates blank-line normalization to an external helper script instead of inline shell commands. The root Makefile renames update-plume-scripts-in-utils to update-plume-scripts, and doc/Makefile and java/Makefile are updated to call the new target. The .gitignore is adjusted to ignore the new .utils directory path.

Possibly related PRs

  • codespecs/daikon#782: Introduces PLUME_SCRIPTS variable and auto-clone behavior alongside target renaming in plume-scripts integration.
  • codespecs/daikon#728: Also modifies plume-scripts integration and renames update-plume-scripts targets across Makefiles.

Suggested reviewers

  • markro49
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.azure/Makefile:
- Around line 1-3: The clone step for PLUME_SCRIPTS may fail if the parent
directory doesn't exist; before running the git clone assigned to the dummy
variable, ensure the parent directory for PLUME_SCRIPTS (the directory portion
of PLUME_SCRIPTS, e.g., ../.utils) is created (mkdir -p) so the git clone into
${PLUME_SCRIPTS} succeeds; update the Makefile around the PLUME_SCRIPTS and
dummy := $(shell git clone ...) lines to create the parent directory first and
then perform the clone if the wildcard check still indicates it's missing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a5fcde1d-9f1c-40c0-9201-59a5ddbcf9bc

📥 Commits

Reviewing files that changed from the base of the PR and between 338e392 and df2db44.

📒 Files selected for processing (5)
  • .azure/Makefile
  • .gitignore
  • Makefile
  • doc/Makefile
  • java/Makefile
💤 Files with no reviewable changes (1)
  • .gitignore

Comment thread .azure/Makefile
@mernst mernst merged commit 526da58 into codespecs:master May 9, 2026
50 checks passed
@mernst mernst deleted the squeezeblanklines branch May 9, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant