Skip to content

Dict: Unneeded#1823

Closed
sebweb3r wants to merge 2 commits into
codespell-project:masterfrom
sebweb3r:unneeded
Closed

Dict: Unneeded#1823
sebweb3r wants to merge 2 commits into
codespell-project:masterfrom
sebweb3r:unneeded

Conversation

@sebweb3r
Copy link
Copy Markdown
Contributor

I'm not sure about this one.

Cambridge doesn't accept unneeded
https://dictionary.cambridge.org/spellcheck/english/?q=unneeded
However aspell does
http://app.aspell.net/lookup?dict=en_US;words=unneeded

Whats the opinion of our natives @lurch @peternewman

moved
unneeded->unnecessary
to informal
@lurch
Copy link
Copy Markdown
Contributor

lurch commented Dec 11, 2020

It does sound a bit odd. I think I'd suggest unneeded->unnecessary, not needed, ?

@peternewman
Copy link
Copy Markdown
Collaborator

The GB large aspell has it too:
http://app.aspell.net/lookup?dict=en_GB-large;words=unneeded

It's in Collins too:
https://www.collinsdictionary.com/dictionary/english/unneeded

So I think it's a usage/style issue at best.

@sebweb3r
Copy link
Copy Markdown
Contributor Author

So how to proceed?
Put it in informal or usage? Or close the PR?

Copy link
Copy Markdown
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another suggestion for the original

uneccessarily->unnecessarily
unecessarily->unnecessarily
unecessary->unnecessary
uneeded->unneeded, needed,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest unheeded too

@peternewman
Copy link
Copy Markdown
Collaborator

So how to proceed?
Put it in informal or usage? Or close the PR?

Up to you, informal would be the right choice if at all I think, usage was the wrong one. I'm not convinced how informal it is personally.

I did just find one improvement to the existing entries though...

@sebweb3r sebweb3r mentioned this pull request Jan 14, 2021
@sebweb3r
Copy link
Copy Markdown
Contributor Author

I will put it in my local dictionary. I created a new MR for your suggestion to not flood the git history.

@peternewman
Copy link
Copy Markdown
Collaborator

I will put it in my local dictionary. I created a new MR for your suggestion to not flood the git history.

Fair enough, thanks for that.

I didn't realise a PR could close another!

@sebweb3r sebweb3r deleted the unneeded branch January 15, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants