fix(vault): trim trailing newlines from kubeconfig before storing in vault add unwrapSOPSData function to handle SOPS data extraction#539
Merged
Conversation
…vault add unwrapSOPSData function to handle SOPS data extraction
…on for SOPS data handling
joka134
requested changes
Jun 29, 2026
…licates from vault encryption tests
joka134
requested changes
Jun 30, 2026
joka134
left a comment
joka134
left a comment
Member
There was a problem hiding this comment.
Looks good. One simple naming comment
joka134
approved these changes
Jul 1, 2026
joka134
pushed a commit
that referenced
this pull request
Jul 1, 2026
…vault add unwrapSOPSData function to handle SOPS data extraction (#539) This pull request introduces several improvements and fixes related to handling kubeconfig storage, SOPS-encrypted vault data, and associated tests. The main changes ensure that kubeconfig files are stored without unwanted trailing newlines, add robust handling for SOPS-encrypted YAML files by unwrapping top-level `data` wrappers, and enhance testing to validate these behaviors. **Kubeconfig storage improvements:** * Trailing newlines are now trimmed from the kubeconfig content before storing it in the vault, preventing YAML formatting issues such as the use of `|+` chomping. * Tests were updated and extended to verify that trailing newlines are properly removed and to ensure the vault file does not contain unwanted YAML formatting. **SOPS/YAML handling improvements:** * Added the `unwrapSOPSData` function to automatically strip a top-level `data` block scalar wrapper from SOPS-encrypted YAML files, ensuring the vault parser receives the intended document structure. * Integrated the unwrapping logic into the vault data parser and made the function available for testing. * Added comprehensive unit tests for `unwrapSOPSData` to verify correct behavior with various YAML inputs, including normal, wrapped, and invalid documents. [Clickup](https://app.clickup.com/t/24560134/869dwweda)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes related to handling kubeconfig storage, SOPS-encrypted vault data, and associated tests. The main changes ensure that kubeconfig files are stored without unwanted trailing newlines, add robust handling for SOPS-encrypted YAML files by unwrapping top-level
datawrappers, and enhance testing to validate these behaviors.Kubeconfig storage improvements:
|+chomping.SOPS/YAML handling improvements:
unwrapSOPSDatafunction to automatically strip a top-leveldatablock scalar wrapper from SOPS-encrypted YAML files, ensuring the vault parser receives the intended document structure.unwrapSOPSDatato verify correct behavior with various YAML inputs, including normal, wrapped, and invalid documents.Clickup