Skip to content

feat: reference extended base image in install-config#63

Merged
siherrmann merged 29 commits intomainfrom
reference-base-image
Nov 3, 2025
Merged

feat: reference extended base image in install-config#63
siherrmann merged 29 commits intomainfrom
reference-base-image

Conversation

@siherrmann
Copy link
Member

@siherrmann siherrmann requested a review from Copilot October 28, 2025 12:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements functionality to reference extended base images in the install-config by adding support for building and pushing custom workspace images. The changes introduce new file parsing capabilities, image management abstractions, and CLI commands for handling container images.

Key Changes:

  • Added configuration parsing for YAML files and OCI image indexes
  • Introduced ImageManager interface with docker/podman support for loading, building, and pushing images
  • Created new build images command for building and pushing container images based on configuration

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
internal/system/image.go New ImageManager implementation supporting docker/podman operations
internal/system/mocks.go Generated mocks for ImageManager interface
internal/installer/files/config_yaml.go Config parsing for YAML with image and flavor definitions
internal/installer/files/oci_image_index.go OCI image index parsing and name extraction
internal/installer/config.go ConfigManager implementation for parsing configs and OCI indexes
internal/installer/package.go Refactored Package to use private fileIO with accessor method
cli/cmd/install_codesphere.go Updated to load and build workspace images during installation
cli/cmd/extend_baseimage.go Refactored to use new ConfigManager and ImageManager interfaces
cli/cmd/build_images.go New command for building and pushing images from config
cli/cmd/build.go New build command group
go.mod Moved gopkg.in/yaml.v3 from indirect to direct dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@siherrmann siherrmann requested a review from NautiluX October 28, 2025 13:09
siherrmann and others added 2 commits October 28, 2025 16:44
Signed-off-by: siherrmann <25087590+siherrmann@users.noreply.github.com>
Copy link
Member

@NautiluX NautiluX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Sorry for the delay, finally got to reading it :)

@siherrmann siherrmann requested a review from Copilot October 31, 2025 12:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 68 out of 69 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@NautiluX NautiluX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @siherrmann ! This PR is huge now, let's please try to iterate on smaller features or parts of them in the future. I'll approve this now so we can manually test and iterate on the commented things later.

@siherrmann siherrmann merged commit 0bbe3a9 into main Nov 3, 2025
6 checks passed
@siherrmann siherrmann deleted the reference-base-image branch November 3, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants