Skip to content

Conversation

@jdungan
Copy link
Member

@jdungan jdungan commented Mar 28, 2017

This is ready to start reviewing, but I'd like to rethink the install experience before publishing.

@jdungan
Copy link
Member Author

jdungan commented Apr 1, 2017

new Install/Update behavior to test on each browser:

  1. De-install addon
  2. Open a codesy home page. Link to addon should be displayed
  3. Open a github issue. Codesy widget should not be displayed
  4. Install the addon and confirm next two steps happen automatically
  5. ** The codesy home page is selected and reloaded. The 'you are ready' page should be displayed.
  6. ** The github issue page will reload in the background
  7. Check the codesy home page for console errors
  8. Select the github issue tab. The widget should be displayed.
  9. Check the console for errors

package.json Outdated
"gulp-zip": "2.0.3",
"merge-stream": "0.1.7",
"gulp-merge-json": "0.5.0",
"jquery": "3.2.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jquery is also in the static directory. This just adds a way to get it with npm install but you still have to manually copy it from node_modules/jquery/dist. I'm not ready to commit time to automating that with gulp.

@groovecoder groovecoder merged commit 9681e06 into master Apr 5, 2017
@groovecoder groovecoder deleted the es6-refactor branch April 5, 2017 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants